Migrate from scalatest to munit. #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an opinionated change, but I'm a firm believer in munit. There were some test issues previously that were pretty hard to debug due to the nasty diffs that scalatest gives you compared to munit. Plus when doing the migration I actually found some mistakes in the tests that were false positives which switching from === to `assertEquals` unveiled. It's a pretty straightforward migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an opinionated change, but I'm a firm believer in munit.
There were some test issues previously that were pretty hard to debug
due to the nasty diffs that scalatest gives you compared to munit. Plus
when doing the migration I actually found some mistakes in the tests that
were false positives which switching from === to
assertEqualsunveiled.It's a pretty straightforward migration.